Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Update Make commands for Mac #250

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

dhaiducek
Copy link
Collaborator

  • Use gsed if Mac is detected
  • Consistently use GOOS and GOARCH for installing binaries
  • Use binaries installed in LOCAL_BIN -- don't rely on the local version
  • Add clean Make target to remove stale binaries

Signed-off-by: Dale Haiducek <[email protected]>
@dhaiducek
Copy link
Collaborator Author

/cc @mprahl @yiraeChristineKim

This (i.e. sed not being the same) is what I was stuck on while @mprahl smoothly fixed everything 😂

@yiraeChristineKim
Copy link
Collaborator

I have been attaching two quotes after sed. And when it is time to commit I removed it lol. This is amazing for me. Thanks Dale

@dhaiducek
Copy link
Collaborator Author

@mprahl There are some non-Mac-specific things in here if you could also review it when you have a moment.

@dhaiducek dhaiducek merged commit f4c0436 into gatekeeper:main Sep 14, 2023
@dhaiducek dhaiducek deleted the mac-make branch September 14, 2023 14:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants